Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechnism to create permissive peerauthenticaion for koperator's default alert manager #856

Merged
merged 3 commits into from Aug 29, 2022

Conversation

panyuenlau
Copy link
Member

@panyuenlau panyuenlau commented Aug 26, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Add mechnism to create permissive peerauthenticaion for koperator's default alert manager while using the helm chart to install koperator

Why?

The users might need this to allow plaintext traffic to go into the default alert manager port for certain applications that do no support mTLS or not easy to configure to support mTLS (e.g. prometheus)

Additional context

To deploy koperator along with the default peerauthentication CR to set alert manager's port to be PERMISSIVE:

helm install koperator charts/kafka-operator --set alertManager.permissivePeerAuthentication.create=true

Note: to have the peerauthentication CR created with koperator installation, the corresponding CRD peerauthentications.security.istio.io/v1beta1 needs to be present in the k8s cluster

Checklist

  • Implementation tested
  • User guide and development docs updated (if needed)

@panyuenlau panyuenlau requested a review from a team as a code owner August 26, 2022 15:19
Copy link
Contributor

@Kuvesz Kuvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@panyuenlau panyuenlau merged commit cfc3d80 into master Aug 29, 2022
@panyuenlau panyuenlau deleted the add-peerauthenticaiton branch August 29, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants