Fix KafkaCluster's status update at CruiseControlTask controller #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
changed the title
Kuvesz
previously approved these changes
Nov 10, 2022
Kuvesz
approved these changes
Nov 10, 2022
panyuenlau
approved these changes
Nov 10, 2022
pregnor
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
KafkaCluster status update happens only when it is necessary.
KafkaCluster status update happens more frequently to avoid an edge case at the CruiseControlTask controller when the code execution exits sooner then the status update
Why?
KafkaCluster status update happened always because a wrong check.
Checklist