Add ability to specify additional container ports for kafka clusters (#897) #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
panyuenlau
reviewed
Nov 23, 2022
There was a problem hiding this comment.
Thanks for the contributions! Can you add an example here https://github.com/banzaicloud/koperator/blob/master/config/samples/banzaicloud_v1beta1_kafkacluster.yaml#L7 to illustrate how this field can be used in the CR?
Sure, I added an example there |
hi-im-aren
force-pushed
the
issue-897
branch
from
99236fd
to
1358e82
Compare
panyuenlau
approved these changes
Nov 30, 2022
pregnor
approved these changes
Nov 30, 2022
Kuvesz
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allows users to specify additional ports to expose from the container.
A new field named 'AdditionalPorts' was added to 'KafkaClusterSpec' with '[]corev1.ContainerPort' type.
Why?
Some kafka distributions have integrated services that expose resources and metrics through a HTTP endpoint. This change allows users to reach those services as well.
Additionally this can be used to open a port for remote debugging.
Additional context
The change was tested manually.
Checklist