Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kafka super.users override #923

Merged
merged 6 commits into from Feb 15, 2023
Merged

Fix Kafka super.users override #923

merged 6 commits into from Feb 15, 2023

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Jan 31, 2023

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Merges custom super.users configuration with the Koperator auto generated one.

Why?

When there is custom super.users configuration in the KafkaCluster CR and there is SSL listener, Koperator generated super.user configuration overrides the custom one.

Additional context

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@bartam1 bartam1 requested a review from a team as a code owner January 31, 2023 17:51
pkg/resources/kafka/configmap.go Outdated Show resolved Hide resolved
pkg/resources/kafka/configmap.go Outdated Show resolved Hide resolved
pkg/resources/kafka/configmap.go Outdated Show resolved Hide resolved
pregnor
pregnor previously approved these changes Feb 13, 2023
panyuenlau
panyuenlau previously approved these changes Feb 13, 2023
pkg/resources/kafka/configmap.go Outdated Show resolved Hide resolved
@bartam1 bartam1 dismissed stale reviews from panyuenlau and pregnor via 9e4ab66 February 15, 2023 08:36
@bartam1 bartam1 merged commit 5a64fb0 into master Feb 15, 2023
@bartam1 bartam1 deleted the superuserfix branch February 15, 2023 15:57
bartam1 added a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants