Rename webhooks errors exported funcs #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaialexandrescu
force-pushed
the
rename_webhooks_errors_exported_funcs
branch
from
fa64fbc
to
1cb447c
Compare
… NOT API breaking
…th IsAdmission prefix; API breaking change
mihaialexandrescu
force-pushed
the
rename_webhooks_errors_exported_funcs
branch
from
1cb447c
to
c7d1fe6
Compare
I vote yes |
pregnor
approved these changes
Feb 9, 2023
Kuvesz
approved these changes
Feb 10, 2023
bartam1
pushed a commit
that referenced
this pull request
Feb 17, 2023
* pkg webhooks: update new error functions names to IsAdmission prefix; NOT API breaking * pkg webhooks: update IsInvalidReplicationFactor exported func name with IsAdmission prefix; API breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR renames the exported error checking functions from pkg
webhooksto names that include theIsAdmission...prefix, rather thanIs..., to hopefully make it clearer that they relate to admission webhooks errors and results.The change is initially done in 2 commits :
IsInvalidReplicationFactorfunction (which already exists in release v0.22.0) is renamed following the same patternWhy?
More clarity and consistency in the naming scheme in the "webhooks" package
API-breaking markers ?
I am not sure what markers I need to use to correctly flag the breaking change in API, other than the table at the top of the PR description.
Still one question about renaming ...
Should the
IsErrorDuringValidationfunction follow the same pattern since it includes the wordvalidationalready ... ? (aka :IsAdmissionErrorDuringValidation)Currently, I favour renaming throughout and it is done for this one too.