-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label router with Match field for Exclude and Select #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarokkk
changed the title
[WIP] Label router with Exclude
[WIP] Label router with Match field for Exclude and Select
Feb 12, 2020
tarokkk
force-pushed
the
label-router-exclude
branch
from
February 12, 2020 15:23
53d36c6
to
fe40291
Compare
tarokkk
force-pushed
the
label-router-exclude
branch
from
February 19, 2020 12:54
a7b055c
to
b7afd59
Compare
tarokkk
changed the title
[WIP] Label router with Match field for Exclude and Select
Label router with Match field for Exclude and Select
Feb 19, 2020
ahma
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarokkk LGTM
pepov
approved these changes
Feb 20, 2020
simonkey007
pushed a commit
to simonkey007/logging-operator
that referenced
this pull request
Mar 11, 2021
* initial advanced routing * create v1beta2 api * extend FLow and ClusterFlow instead of API v1beta2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR contains major changes in the CRD spec!
selector
inFlow
andClusterFlow
The attribute will still be available however using the
match
field is preferable.match
Differently from
selectors
, match is a list ofselect
andesclude
statement. The expressionsevaluated in order and the first positive or negative match will break the evaluation.
Detailed documentation will be available in the docs.
Additional context
With this change we can handle several so far unavailable scenarios of log routing.
Checklist