Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label router with Match field for Exclude and Select #357

Merged
merged 12 commits into from
Feb 20, 2020
Merged

Conversation

tarokkk
Copy link
Contributor

@tarokkk tarokkk commented Feb 12, 2020

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? yes
License Apache 2.0

What's in this PR?

This PR contains major changes in the CRD spec!

  • Deprecation of selector in Flow and ClusterFlow
    The attribute will still be available however using the match field is preferable.
  • New field: match
    Differently from selectors, match is a list of select and esclude statement. The expressions
    evaluated in order and the first positive or negative match will break the evaluation.

Detailed documentation will be available in the docs.

Additional context

With this change we can handle several so far unavailable scenarios of log routing.

Checklist

  • Manual testing upgrade and actual workflows
  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@tarokkk tarokkk changed the title [WIP] Label router with Exclude [WIP] Label router with Match field for Exclude and Select Feb 12, 2020
@tarokkk tarokkk requested review from pepov and ahma and removed request for pepov February 12, 2020 15:22
@tarokkk tarokkk marked this pull request as ready for review February 19, 2020 10:20
@tarokkk tarokkk changed the title [WIP] Label router with Match field for Exclude and Select Label router with Match field for Exclude and Select Feb 19, 2020
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarokkk LGTM

@ahma ahma merged commit b846e1a into master Feb 20, 2020
@ahma ahma deleted the label-router-exclude branch February 20, 2020 09:33
simonkey007 pushed a commit to simonkey007/logging-operator that referenced this pull request Mar 11, 2021
* initial advanced routing
* create v1beta2 api
* extend FLow and ClusterFlow instead of API v1beta2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants