fix: logging-operator-logging logging.yaml template #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sermilrod
force-pushed
the
fix/logging-operator-logging-template
branch
from
de938f7
to
4909636
Compare
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
sermilrod
force-pushed
the
fix/logging-operator-logging-template
branch
from
4909636
to
484005a
Compare
tarokkk
requested changes
Aug 3, 2020
| enabled: false | ||
| secretName: {{ .Values.tls.fluentdSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentd-tls" ) }} |
There was a problem hiding this comment.
Suggested change
| secretName: {{ .Values.tls.fluentdSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentd-tls" ) }} |
| enabled: false | ||
| secretName: {{ .Values.tls.fluentdSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentd-tls" ) }} | ||
| sharedKey: "{{ .Values.tls.sharedKey }}" |
There was a problem hiding this comment.
Suggested change
| sharedKey: "{{ .Values.tls.sharedKey }}" |
| enabled: false | ||
| secretName: {{ .Values.tls.fluentbitSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentbit-tls" ) }} |
There was a problem hiding this comment.
Suggested change
| secretName: {{ .Values.tls.fluentbitSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentbit-tls" ) }} |
| enabled: false | ||
| secretName: {{ .Values.tls.fluentbitSecretName | default (printf "%s-%s" (include "logging-operator-logging.name" . ) "fluentbit-tls" ) }} | ||
| sharedKey: "{{ .Values.tls.sharedKey }}" |
There was a problem hiding this comment.
Suggested change
| sharedKey: "{{ .Values.tls.sharedKey }}" |
It is required by the Fluentbit/Fluentd spec regardless of the value of the field By the look of it only |
|
I think we should change that to omitempty as well to be consistent in the API. However, we can merge this and do some follow up commits to clean things up- |
tarokkk
approved these changes
Aug 3, 2020
simonkey007
pushed a commit
to simonkey007/logging-operator
that referenced
this pull request
Mar 11, 2021
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
EppO
pushed a commit
to EppO/logging-operator
that referenced
this pull request
Apr 21, 2021
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Modifications to logging.yaml template to fix logging object when it renders without TLS enabled
Why?
Running tls.enabled=false produces invalid yaml
Checklist