Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless -d date in fluentd healthcheck #605

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Remove useless -d date in fluentd healthcheck #605

merged 1 commit into from
Oct 28, 2020

Conversation

worr
Copy link
Contributor

@worr worr commented Oct 22, 2020 •
edited

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Remove the useless -d date in the healthcheck, as was done in the v10 image.

Why?

Due to an oversight, I unfortunately did not include this in #539. Sorry about that.

@ahma ahma self-requested a review October 24, 2020 13:13
ahma
ahma approved these changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahma ahma requested a review from tarokkk October 24, 2020 13:13
@tarokkk tarokkk merged commit cfed9c7 into kube-logging:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worr @tarokkk @ahma