Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recommendation errors and failures handled unanimously #217

Merged
merged 3 commits into from
May 13, 2019
Merged

recommendation errors and failures handled unanimously #217

merged 3 commits into from
May 13, 2019

Conversation

lpuskas
Copy link
Member

@lpuskas lpuskas commented May 10, 2019

  • wrapped / tagged errors during recommendations in order to provide consistent error codes in responses

relates to #173

@lpuskas lpuskas requested a review from prekoa May 10, 2019 15:52
@lpuskas lpuskas self-assigned this May 10, 2019
@lpuskas lpuskas marked this pull request as ready for review May 12, 2019 09:24
prekoa
prekoa approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@prekoa prekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @lpuskas

@lpuskas lpuskas merged commit 1d03374 into master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prekoa prekoa prekoa approved these changes

Assignees

@lpuskas lpuskas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lpuskas @prekoa