ec2 refactor, unit test correction #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpuskas
requested changes
Jun 14, 2018
| "github.com/aws/aws-sdk-go/service/pricing" | ||
| "github.com/banzaicloud/telescopes/productinfo" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| type DummyPricingSource struct { | ||
| type dummy struct { |
There was a problem hiding this comment.
please use a better name for this and document what it is intended for
| return &ec2.DescribeAvailabilityZonesOutput{ | ||
| AvailabilityZones: []*ec2.AvailabilityZone{ | ||
| { | ||
| State: aws.String("available"), |
There was a problem hiding this comment.
please check if there are constants in the ec2 library for the strings here
| name: "success - create a new config instance", | ||
| check: func(config *aws.Config) { | ||
| assert.NotNil(t, config, "the config should not be nil") | ||
| name: "successful - get current sport prices", |
added 2 commits
June 14, 2018 11:50
lpuskas
approved these changes
Jun 14, 2018
|
Fixes #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.