Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraArgs to store spec #71

Closed
wants to merge 1 commit into from

Conversation

craigfurman
Copy link

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets implements #70, indirectly.
License Apache 2.0

What's in this PR?

Adds an "extraArgs" field to the store gateway spec, so that users can pass arbitrary flags to thanos-store.

Why?

Additional context

I am not particularly up to date with operator development, and am not sure I've done this the right way. I ran make genall after making my change. This generated some docs. Is this the right sort of thing to do, or are there steps or considerations I've missed?

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@pepov
Copy link
Contributor

pepov commented Mar 26, 2021

Sorry we haven't been responsing to this so far! I beleive we've added all the missing arguments to the StoreGateway API type and a bit against supporting arbitrary flags, but in case you would still need this, we can consider adding them to all workloads to be consistent.

Feel free to open an issue, I'm closing this.

@pepov pepov closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants