Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Props 'phone' in model CustomerModel #77

Closed
marconneves opened this issue Jul 3, 2020 · 1 comment
Closed

Props 'phone' in model CustomerModel #77

marconneves opened this issue Jul 3, 2020 · 1 comment

Comments

@marconneves
Copy link

marconneves commented Jul 3, 2020 •
edited
Loading

Describe the bug
In some cases the user can put only phone and not a mail, in this case on Type CustomerModel don't have this possibility.

To Reproduce
Steps to reproduce the behavior:

  1. Now type model is 'https://github.com/banzeh/cielo/blob/master/src/models/customer.model.ts'
  2. On this doc has the value Phone, on this response have a phone, but in response of payment consult has too.
    https://developercielo.github.io/manual/cielo-ecommerce#resposta117
  3. See error

Expected behavior
You can check this think please?
@marconneves
Copy link
Author

Others 2 props don't have on PaymentResponseModel, you can check please?
is capturedDate and receivedDate.

banzeh added a commit that referenced this issue Jul 5, 2020
@banzeh
fix: adicionado campos nas models
d5c18c7 
Adicionado campos de request que não estavam na model

#77
@banzeh banzeh mentioned this issue Jul 5, 2020
Merged
banzeh added a commit that referenced this issue Jul 5, 2020
@banzeh
Merge pull request #78 from banzeh/fix/#77
7fd1677 
fix: adicionado campos nas models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marconneves