Check for variables that must defined in ci.mk #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits introduces the 'util.mk' makefile meant as a repository for utility defintions. Initially the only utility defined is 'check_variable_defined' to provide a standard way for makefiles to check if a variable is defined. Signed-off-by: Jose Martins <josemartins90@gmail.com>
josecm
requested review from
AfonsoSantos96 and
miguelafsilva5
as code owners
|
@DavidMCerdeira could you verify this fixes #32? |
josecm
force-pushed
the
fix/check_defined_make_variables
branch
from
9600261
to
dcf3b8a
Compare
miguelafsilva5
previously approved these changes
Jan 20, 2023
DavidMCerdeira
requested changes
Jan 23, 2023
|
@miguelafsilva5 @AfonsoSantos96 anything holding up this PR? |
|
@josecm, @DavidMCerdeira seems to be having issues with this PR. Check his message above. |
Certain variables must be defined before including 'ci.mk' or instantiating some of its rules. This commits adds checks for two of them 'root_dir' that should contain the repositories root directory where the ci repo is located, and 'cc' which defines the compiler to be used. Signed-off-by: Jose Martins <josemartins90@gmail.com>
josecm
force-pushed
the
fix/check_defined_make_variables
branch
from
dcf3b8a
to
4636d53
Compare
@DavidMCerdeira I believe this was fixed in the last commit. |
DavidMCerdeira
approved these changes
Feb 16, 2023
AfonsoSantos96
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As pointed out in #32, certain variables such as 'cc' must be defined by the Makefile that instantiates certain CI rules. There was no measure put in place to check that these variables were indeed defined. This PR introduces these checks by: