detect if the instance created extends or direct instance of Smooth

[baptistebriel]

Currently to extend Smooth in your own file you have to pass an option. I need to know if the instance created extends Smooth or is direct instance of Smooth.

https://github.com/baptistebriel/smooth-scrolling/blob/master/index.js#L17

I've done this so smooth-scrolling.js could be used on its own without going into the build process.

[Awea]

@baptistebriel something like this this.extends = this.constructor.name != 'Smooth' in the constructor ?

[baptistebriel]

Awesome, thanks for the hint @Awea ! 👍

[Awea]

@baptistebriel np :) Now I wish I can do what I want with this library !

[baptistebriel]

Are you having issues with it? Don't hesitate to ask 🙂

[Awea]

If I get stuck at some point yeah, thanks !

[jghlt]

Hi
great library thanks!

When I extend the Class, vars.bounding is never set.

index.js line 288

if(!this.extends) {
  const bounding = this.dom.section.getBoundingClientRect()
  this.vars.bounding = this.vars.direction === 'vertical' ? bounding.height - (this.vars.native ? 0 : this.vars.height) : bounding.right - (this.vars.native ? 0 : this.vars.width)
}

Is this desired behaviour?

[Awea]

Hi @jghlt,

The vars.boundings is correctly set using one of the demo. Can you please provide an example where this is not the case ? :)

[baptistebriel]

Hello @jghlt,

Yes indeed, this is an expected behaviour; when you use an extended version of Smooth, you might want to set this.vars.bounding manually because it could be something else rather than the height of this.dom.section. I did this so you could have more control on the scrollable content, while being able to use smooth-scrolling.min.js without extending it.

Let me know what you think!

[jghlt]

@Awea in the demos it seems to be explicitly set again within the custom.js for each demo.

@baptistebriel Cool, its not a big deal to have to set this again, but might be nice to have an option to retain the default functionality, unless I'm thinking about this in the wrong way?

[baptistebriel]

We could check something like this:

if(!this.extends || this.options.keepDefaultBounding) {
  const bounding = this.dom.section.getBoundingClientRect()
  this.vars.bounding = this.vars.direction === 'vertical' ? bounding.height - (this.vars.native ? 0 : this.vars.height) : bounding.right - (this.vars.native ? 0 : this.vars.width)
}

... but it adds another option, and I thought it would be just simpler to have complete control on the amount of pixels it can scrolls when it's a custom class of smooth-scrolling.

[jghlt]

I agree its better to keep options to a minimum, but I think it would be good to have the option to maintain the default behaviour in this instance, what do you think?