Skip to content

Commit

Permalink
Add more tests when fields are qualified.
Browse files Browse the repository at this point in the history
  • Loading branch information
bar committed Dec 3, 2013
1 parent 3c484a5 commit 2603546
Showing 1 changed file with 127 additions and 0 deletions.
127 changes: 127 additions & 0 deletions lib/Cake/Test/Case/Model/Datasource/DboSourceTest.php
Expand Up @@ -1069,6 +1069,47 @@ public function fieldsCacheKey() {
array('title', null, 'title'),
)),

// One valid qualified field
array(array(
// correct
'Article.title',
array('Article.title'),

// duplicated
'Article.title, Article.title',
array('Article.title', 'Article.title'),

// empty
'Article.title, ',
'Article.title, ',
'Article.title, 0',
array('Article.title, '),
array('Article.title, '),
array('Article.title, 0'),
array('Article.title', ''),
array('Article.title', ' '),
array('Article.title', ' '),
array('Article.title', '0'),
array('Article.title', 0),
array('Article.title', false),
array('Article.title', null),

// empty + duplicated
'Article.title, , Article.title',
'Article.title, , Article.title',
'Article.title, 0, Article.title',
array('Article.title, , Article.title'),
array('Article.title, , Article.title'),
array('Article.title, 0, Article.title'),
array('Article.title', '', 'Article.title'),
array('Article.title', ' ', 'Article.title'),
array('Article.title', ' ', 'Article.title'),
array('Article.title', '0', 'Article.title'),
array('Article.title', 0, 'Article.title'),
array('Article.title', false, 'Article.title'),
array('Article.title', null, 'Article.title'),
)),

// Multiple valid unqualified fields
array(array(
// correct
Expand Down Expand Up @@ -1110,6 +1151,92 @@ public function fieldsCacheKey() {
array('title', 'body', 0, 'title'),
array('title', 'body', false, 'title'),
array('title', 'body', null, 'title'),
)),

// Multiple valid qualified fields
array(array(
// correct
'Article.title, Article.body',
array('Article.title, Article.body'),
array('Article.title', 'Article.body'),

// duplicated
'Article.title, Article.body, Article.title',
array('Article.title, Article.body, Article.title'),
array('Article.title', 'Article.body', 'Article.title'),

// empty
'Article.title, Article.body, ',
'Article.title, Article.body, ',
'Article.title, Article.body, 0',
array('Article.title, Article.body, '),
array('Article.title, Article.body, '),
array('Article.title, Article.body, 0'),
array('Article.title', 'Article.body', ''),
array('Article.title', 'Article.body', ' '),
array('Article.title', 'Article.body', ' '),
array('Article.title', 'Article.body', '0'),
array('Article.title', 'Article.body', 0),
array('Article.title', 'Article.body', false),
array('Article.title', 'Article.body', null),

// empty + duplicated
'Article.title, Article.body, , Article.title',
'Article.title, Article.body, , Article.title',
'Article.title, Article.body, 0, Article.title',
array('Article.title, Article.body, , Article.title'),
array('Article.title, Article.body, , Article.title'),
array('Article.title, Article.body, 0, Article.title'),
array('Article.title', 'Article.body', '', 'Article.title'),
array('Article.title', 'Article.body', ' ', 'Article.title'),
array('Article.title', 'Article.body', ' ', 'Article.title'),
array('Article.title', 'Article.body', '0', 'Article.title'),
array('Article.title', 'Article.body', 0, 'Article.title'),
array('Article.title', 'Article.body', false, 'Article.title'),
array('Article.title', 'Article.body', null, 'Article.title'),
)),

// Multiple valid unqualified and qualified fields
array(array(
// correct
'Article.title, body',
array('Article.title, body'),
array('Article.title', 'body'),

// duplicated
'Article.title, body, Article.title',
array('Article.title, body, Article.title'),
array('Article.title', 'body', 'Article.title'),

// empty
'Article.title, body, ',
'Article.title, body, ',
'Article.title, body, 0',
array('Article.title, body, '),
array('Article.title, body, '),
array('Article.title, body, 0'),
array('Article.title', 'body', ''),
array('Article.title', 'body', ' '),
array('Article.title', 'body', ' '),
array('Article.title', 'body', '0'),
array('Article.title', 'body', 0),
array('Article.title', 'body', false),
array('Article.title', 'body', null),

// empty + duplicated
'Article.title, body, , Article.title',
'Article.title, body, , Article.title',
'Article.title, body, 0, Article.title',
array('Article.title, body, , Article.title'),
array('Article.title, body, , Article.title'),
array('Article.title, body, 0, Article.title'),
array('Article.title', 'body', '', 'Article.title'),
array('Article.title', 'body', ' ', 'Article.title'),
array('Article.title', 'body', ' ', 'Article.title'),
array('Article.title', 'body', '0', 'Article.title'),
array('Article.title', 'body', 0, 'Article.title'),
array('Article.title', 'body', false, 'Article.title'),
array('Article.title', 'body', null, 'Article.title'),
))
);
}
Expand Down

0 comments on commit 2603546

Please sign in to comment.