Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #41

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Misc improvements #41

merged 6 commits into from
Jul 21, 2021

Conversation

dhui
Copy link
Contributor

@dhui dhui commented Jul 14, 2021

Various improvements include:

  • only set -common_args option if there are addition init args
  • fix typo
  • wait for exiftool command to exit on Close()
  • Run tests that call NewExiftool in parallel (for me, test runtimes dropped from 3-4s to ~1s)
  • Run CI on push and pull requests

exiftool.go Outdated Show resolved Hide resolved
@dhui dhui requested a review from barasher July 18, 2021 03:30
exiftool.go Show resolved Hide resolved
exiftool.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #41 (699bee9) into master (f55d3fd) will increase coverage by 1.25%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   88.19%   89.44%   +1.25%     
==========================================
  Files           2        2              
  Lines         144      180      +36     
==========================================
+ Hits          127      161      +34     
- Misses         11       13       +2     
  Partials        6        6              
Impacted Files Coverage Δ
exiftool.go 83.33% <76.19%> (+3.10%) ⬆️
filemetadata.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55d3fd...699bee9. Read the comment docs.

@barasher barasher added this to the v1.6.2 milestone Jul 21, 2021
@barasher barasher self-assigned this Jul 21, 2021
@barasher barasher merged commit c0795e3 into barasher:master Jul 21, 2021
@dhui dhui deleted the misc-improvements branch July 21, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants