-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final project - Linear vortex panel method #5
base: master
Are you sure you want to change the base?
Conversation
Nice job, overall. What I missed was a concluding section where you explain what you gained from this project. It would have been easy to run the vortex-source panel method and compare it with the experimental data you have, and say something about how the two methods compare in the number of panels needed to achieve a certain percentage error. On the other hand, it would've been nice to have a brief discussion of the fact that a panel method is never expected to really match experimental data. It's potential theory, after all! And I would have expected significant deviation from potential theory at 10º angle of attack. What is the stall angle of this airfoil? I'm actually surprised that the difference is only 3.5%. It would be satisfying to have some final commentary on the pros and cons of this version of the panel method, instead of simply leaving it as an exercise for the reader! Typos, grammar, etc. how to apply panel method—> methods Then, to get a solution with circulation we add, to the constant source panel method, vortices to our panels and that allows us to may have lift force.—> Then, to get a solution with circulation, we add vortices to the constant-source panel method, allowing us to obtain an lift force. (…check commas, wording and ordering) (Lesson11)—> missing space However, in this case we need to use linear elements instead of use constant ones—> instead of using What does linear elements mean? —> This is awkward: "elements" is a plural noun, so there is a verb mis-match with "does." But this also sounds a bit awkward: "What do linear elements mean?" (although it's grammatically correct) singularities distribution —> singularity distributions If we discretize into N panels—> If we discretize the geometry into N panels (or "the airfoil" or whatever: missing object of the verb) I think you need to add a line break after the text underneath equation (5), so that next equation is rendered correctly. Or maybe a missing underdash for gamma? the length of the panel j —> the length of panel j After equation (7), you have three sentences beginning with "then." Most of the time, this word is superfluous and can be deleted without any loss. the strength singularities—> the singularity strengths? So for the flow-tangency—> do you really need "so"? we are gonna use—> Nooooooo!!!!!! Never again. Promise? So following the same idea—> do you really need "so"? define two integrate functions on to solve—>define two functions to compute There is a floating period after the equation for the linear system. So we will call—> do you really need "so"? A2 correspond to γj and A3 correspond to γj+1 —> corresponds This is the moment, where you should—> This is the moment when you should (no comma)
So yes, our matrix will have—> do you really need "so yes"? Now we have the solution of our system we can get—> Now that we have the solution of our system, we can get (note the comma So, we have to compute the tangential velocity—> do you really need "so"? B1 the term related—> B1, the term related (comma) (you left quotes for writing docstring on From Lesson 10 we kow—> know So let's calculate solve the problem—> do you really need "so"? Delete "calculate." less than 5% what is an acceptable value. —> less than 5%, which is an acceptable value. (Better: "which may be an acceptable value," because "acceptable" is not an absolute.) it is not worthy to solve—> it is not worthwhile to solve |
Thank you for the feedback, I'm going to work on that! About the 3.5% . I've just found the original paper, and they said that the experimental data is from "low-speed wind tunnel on a two-dimensional model of NACA 0012 aerofoil. " |
I don't understand what you mean with "that's the reason they match well." There's no such thing as a two-dimensional model in experiments. There will always be 3D effects! Besides, you can't get rid of viscosity in real life … |
Panel methods should actually work pretty well for calculating the lift of thin airfoils with attached flow. 3D effects are low for thin airfoils, and the pressure distribution around the airfoil is approximately the same even with a boundary layer (dp/dn is approximately zero, and boundary layers are very thin at high Re). And it looks like the NACA 0012 stalls at 16 deg AoA, so the good match is not surprising. |
Here is my final project : Linear vortex panel method.
Open to suggestions 👍