Change flag margins to restore previous row height #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change from GridView to RecyclerView (#104), a change was made from GridView's rowHeight of 16dp and verticalSpacing of 1dp to... well, they simply weren't retained. Due to the sizes of the flag images (they're squares instead of rectangles), the rows grew higher to accommodate them, causing fewer rows to appear on the screen -- on my 4.5" 720x1280 Moto G, the number of rows went from 16 to 13. This proposed change (-2.5dp vertical margin) restores the layout to the previous row height. (I did try setting layout_height to 16dp, but that caused the `ScaleType.FIT_START` to resize the flag smaller.) Note: I haven't tested this on any other devices, so I don't know if the same row count change will occur elsewhere. (I'm on WinXP, no Intel HAXM support for emulator images, 'twas a bit of an ordeal just getting Android Studio working on it; using 2.3.3.)
|
|
|
Thanks @goldfndr for testing this! Could you provide before and after screenshots on your device? I'll take a look at this on devices I have as well. |
|
Here you go, before and after shots.
|
|
Thanks @goldfndr! This patch works as a work-around - the "right" way to do this is probably to resize the images as rectangles instead of squares. Interestingly, the source images are rectangles, but it looks like the Android Icon Generator changed them to squares. I may resize all the flags to rectangles that at some point, but for now this will do. Here's what it looks like on a Samsung Galaxy S8+ (master branch left, this PR right):
|
|
I opened a new issue for cropping the flag images at #111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change from GridView to RecyclerView (#104), a change was made from GridView's rowHeight of 16dp and verticalSpacing of 1dp to... well, they simply weren't retained. Due to the sizes of the flag images (they're squares instead of rectangles), the rows grew higher to accommodate them, causing fewer rows to appear on the screen -- on my 4.5" 720x1280 Moto G, the number of rows went from 16 to 13. This proposed change (-2.5dp vertical margin) restores the layout to the previous row height. (I did try setting layout_height to 16dp, but that caused the
ScaleType.FIT_STARTto resize the flag smaller.)Note: I haven't tested this on any other devices, so I don't know if the same row count change will occur elsewhere. (I'm on WinXP, no Intel HAXM support for emulator images, 'twas a bit of an ordeal just getting Android Studio working on it; using 2.3.3.)
Please make sure these boxes are checked before submitting your pull request - thanks!
Acknowledge that you're contributing your code under Apache v2.0 license
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.If you have multiple commits please combine them into one commit by squashing them.