feat: Log GnssAntennInfo to JSON file

[barbeau]

This PR implements logging of GnssAntennInfo to a JSON file.

Closes #419.

TODO:

• Test on a real Android 11 device that supports this
• Add missing closing ]
• Test orientation changes with CSV file
• Flush JSON file?
• Test sharing current CSV file
• Test sharing existing CSV file via browser
• Add docs

Does anyone have an Android 11 device that would be willing to run a test build and see if this works? A Pixel 4a is the only Android 11 device I have access to and it doesn't support GnssAntennaInfo.

Test builds:

• Google Play version - https://www.dropbox.com/s/pdrn7l8zbvr8134/googleRelease-v3.8.3-antenna-log.apk?dl=1
• F-Droid version - https://www.dropbox.com/s/9dpr3ks87um0in7/osmdroidRelease-v3.8.3-antenna-log.apk?dl=1

In the test build, you can check support by going to GPSTest "Settings->Logging and Output" and see if the "Antenna Info" is checkable or if it's grayed out.

After you check the box and return to the Status screen, the app should create a new JSON log file in the "gnss_log" folder on your device. If you could share that file, it would be awesome. And, if your device w/ Android 11 doesn't support the feature, please let me know.

[alexlopezc]

Tested Google Play version in Pixel 4 with Android 11 build RP1A.200720.009 and Antenna Info is not checkeable.

[Jakazuuu]

Tested with Google Play version on Pixel 5 with Android 11 build RD1A.200810.021.A1 and getting "cloud not open file" exception.

Solved the exception with adding android:requestLegacyExternalStorage="true" to the Application-Tag in AndroidManifest.xml

With that I got a nice looking JSON file with all data.
pixel5_antennaInfo.txt

[barbeau]

@Jakazuuu Ooo, nice! Thanks for testing! Good catch on the external storage issue, I just opened a bug here - #446.

JSON overall looks good, although it does look like it's missing a closing ]. I'll work on fixing that too.

[barbeau]

@Jakazuuu I've updated the above test build links with a few fixes, would you mind trying again and seeing if everything works as expected?

[Jakazuuu]

@barbeau Sure! I'll test it later the day and give you an update!

[Jakazuuu]

@barbeau I just tested the updated APK.

The issue with the storage is fixed.

Also the missing ] at the end of the JSON file is fixed when the file streams are correctly closed. When closing the app via "Return" I got a toast notification "Unable to close all file streams" and the corresponding JSON file is missing the ].

Another bug is, when checking more than one "File Output", I got a toast notification with "Logging to new file: %1$s, .json".

[barbeau]

Thanks @Jakazuuu!

Another bug is, when checking more than one "File Output", I got a toast notification with "Logging to new file: %1$s, .json".

Ah, good catch, I just posted a new test build that should fix this.

Also the missing ] at the end of the JSON file is fixed when the file streams are correctly closed.

What UI steps did you take when the file wasn't missing the ]?

When closing the app via "Return" I got a toast notification "Unable to close all file streams" and the corresponding JSON file is missing the ].

Do you mean when you close the app using the back button?

I added something that might fix this to the new test build, if you could try testing again.

The three main scenarios to test while logging CSV and JSON files would be:

1. Kill the app with the back button. Files should be closed without error and when you start the app again it should log to new files.
2. Tap the home button to background the app, then return to it. Depending on how aggressive Android in killing background Activities it may resume logging to the old files, or start logging to new files. But hopefully 🤞 no errors either way.
3. Tap "Share" button in action bar, file share button, and choose email client, and hopefully both CSV and JSON files should be attached to email and logging should start again with new files after sharing is complete.

[Jakazuuu]

Hi @barbeau, I tested the new build and everything is working now! Thank you very much.

I tested the three main scenarios with activated NMEA and AntennaInfo logging.

1. Kill the app with the back button. Files should be closed without error and when you start the app again it should log to new files.

Clicking back, stops logging without an error. 👍

2. Tap the home button to background the app, then return to it. Depending on how aggressive Android in killing background Activities it may resume logging to the old files, or start logging to new files. But hopefully 🤞 no errors either way.

Also, this one is working like intended. For my Pixel 5 its resume logging to the old files. 👍

3. Tap "Share" button in action bar, file share button, and choose email client, and hopefully both CSV and JSON files should be attached to email and logging should start again with new files after sharing is complete.

Here the files are attached to the email and the logger starts with new files. 👍

Do you mean when you close the app using the back button?

Yes, that was exactly what I meant!

[barbeau]

Thanks @Jakazuuu, I appreciate you testing it!