New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling library has no effect if someone is using a helper. #7
Comments
@shashankkrjain I don't have so much time to test it with Laravel. Could you please check if now everything works fine? But don't forget to run |
Okay, I am checking this. Will get back to you |
This works fine. Thanks for the fix :) |
That's great! I published release including this fix https://github.com/barbushin/php-console-laravel/releases/tag/5.1 Thanks for report! 👍 |
If I disable the library in config, but I am using helper, then log messages are still logged in console.
Ideal behavior would be to log messages when library is enabled, but don't log and simply skip the messages if library is disabled. This will make moving from development to production very easy.
For example,
PC::debug("Hello!");
Should send log message to console when library is enabled, but should not do anything if its disabled.
The text was updated successfully, but these errors were encountered: