Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling library has no effect if someone is using a helper. #7

Closed
shashankkrjain opened this issue Jun 30, 2015 · 4 comments
Closed

Comments

@shashankkrjain
Copy link

If I disable the library in config, but I am using helper, then log messages are still logged in console.

Ideal behavior would be to log messages when library is enabled, but don't log and simply skip the messages if library is disabled. This will make moving from development to production very easy.

For example,

PC::debug("Hello!");

Should send log message to console when library is enabled, but should not do anything if its disabled.

barbushin added a commit to barbushin/php-console that referenced this issue Jun 30, 2015
@barbushin
Copy link
Owner

@shashankkrjain I don't have so much time to test it with Laravel. Could you please check if now everything works fine? But don't forget to run composer update because this fix depends on new php-console release 3.1.4. Thank you!

@barbushin barbushin reopened this Jun 30, 2015
@shashankkrjain
Copy link
Author

Okay, I am checking this. Will get back to you

@shashankkrjain
Copy link
Author

This works fine. Thanks for the fix :)

@barbushin
Copy link
Owner

That's great! I published release including this fix https://github.com/barbushin/php-console-laravel/releases/tag/5.1

Thanks for report! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants