Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] PHP 8.1 compatibility #624

Closed
ThomasLandauer opened this issue Nov 23, 2021 · 6 comments · Fixed by #636 or #644
Closed

[Feature Request] PHP 8.1 compatibility #624

ThomasLandauer opened this issue Nov 23, 2021 · 6 comments · Fixed by #636 or #644
Labels
enhancement This will enhance this library. needs investigation This will be tested / debugged or checked out. phpunit Adding or updating PHPUnit tests for this issue.

Comments

@ThomasLandauer
Copy link
Contributor

What's the plan/status for upgrading to PHP 8.1?
Here's what probably needs to be fixed: https://php.watch/versions/8.1/IMAPConnection-resource
@ThomasLandauer ThomasLandauer added the needs investigation This will be tested / debugged or checked out. label Nov 23, 2021
@Sebbo94BY Sebbo94BY added enhancement This will enhance this library. phpunit Adding or updating PHPUnit tests for this issue. labels Nov 23, 2021
@Sebbo94BY
Copy link
Collaborator

Ah, I was just so happy, that PHP 8.0 support has been added and now there is again such a "big" project...

Man Crying

I don't have any status or plans regarding this yet as I wanted to clean up the open pull requests and issues first, which... will take some time.

But as always: Everyone is welcome to create pull requests to support this project. :)

@Sebbo94BY Sebbo94BY mentioned this issue Nov 26, 2021
Closed
@ThomasLandauer ThomasLandauer mentioned this issue Dec 3, 2021
Merged
@Sebbo94BY
Copy link
Collaborator

@ThomasLandauer Looks like as some de-/encoding stuff breaks with PHP 8.1:

Mailbox (PhpImap\Mailbox)
 ✘ Encoding to utf 7 decode back to utf 8 with data set "chiCheŵa" [0.20 ms]
   │
   │ Failed asserting that two strings are equal.
   │ --- Expected
   │ +++ Actual
   │ @@ @@
   │ -'chiCheŵa'
   │ +'chiCheŵa'
   │
   │ /home/runner/work/php-imap/php-imap/tests/unit/MailboxTest.php:443
   │

See https://github.com/barbushin/php-imap/runs/4415332297.

@ThomasLandauer
Copy link
Contributor Author

Sorry, don't know what's going on there :-(

@MaSpeng MaSpeng mentioned this issue Dec 10, 2021
Merged
Sebbo94BY added a commit that referenced this issue Dec 15, 2021
@Sebbo94BY
Merge pull request #644 from MaSpeng/feature/624-php-8-1-compatibility
284aa72 
#624: Provide PHP 8.1 compatibility
@nunoperalta
Copy link

@Sebi94nbg @MaSpeng Any estimated date when the new version/package will be released? :)
Thank you very much! Good day.

@MaSpeng
Copy link
Contributor

MaSpeng commented Dec 17, 2021

@nunoperalta I am sorry but I only provided the pr for the compatibility, I can not provide any information regarding the next release. It seems that @Sebi94nbg merged the pr into the development branch which seems to introduce a test matrix for the supported PHP versions. Maybe @Sebi94nbg can bring more light to that topic ^^.

@Sebbo94BY
Copy link
Collaborator

This change is included in the release 4.3.0 and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This will enhance this library. needs investigation This will be tested / debugged or checked out. phpunit Adding or updating PHPUnit tests for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hacking PHP 8.1 compatibility ThomasLandauer/php-imap
#624: Provide PHP 8.1 compatibility
4 participants
@nunoperalta @ThomasLandauer @Sebbo94BY @MaSpeng