Lazy load message text and attachments data #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes barbushin#150 barbushin#167 barbushin#122 as discussed at barbushin#284 instead of trying to avoid loading attachments rather put it off until it is needed. we can do the same for text plain and text html as well, what you don't need won't be retrieved. solution remains non breaking, public lazy load properties are implemented as property magic getter
|
Also fixes #241 or at least moving in the right direction |
|
Just tested it quickly with my test script and some test emails, which were used to reproduce some reported issues. These changes work as expected. Backward compatibility is given. All PHPUnit tests are still successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something along these lines...
fixes #150 #167 #122 as discussed at #284
instead of trying to avoid loading attachments rather put it off until it is needed.
we can do the same for text plain and text html as well, what you don't need won't be retrieved.
solution remains non breaking, public lazy load properties are implemented as property magic getter
nJoy!