Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer installable via NPM #1

Closed
mvberg opened this issue Oct 9, 2018 · 5 comments
Closed

No longer installable via NPM #1

mvberg opened this issue Oct 9, 2018 · 5 comments

Comments

@mvberg
Copy link
Member

mvberg commented Oct 9, 2018

Since @barchart/instruments-client-js went private

https://gist.github.com/mvberg/0d40b31bc643f3d7d115384cba42af33#file-npm4040-log-L1

preferable way to fix would be to use "git+ssh://git@github.com/..." paths (so we do not have to npm login)

@bryaningl3

@facetrollex @nikitakonan

@bryaningl3
Copy link
Contributor

bryaningl3 commented Oct 9, 2018 via email

@mvberg
Copy link
Member Author

mvberg commented Oct 9, 2018

i'm just going to override (or provide) your dependency via SSH in my app.

not worth having my team of 5 devs (and growing!) now have to login in to NPM - just a another way to increase friction.

thanks for the response.

@mvberg mvberg closed this as completed Oct 9, 2018
@bryaningl3
Copy link
Contributor

bryaningl3 commented Oct 9, 2018 via email

@mvberg
Copy link
Member Author

mvberg commented Oct 9, 2018

can you elaborate on why you disagree?

are you saying that sharing a master password or "root account" via npm login across all teams (including contractors, etc) is good practice? or are you suggesting that one should share a SSH key with other developers who need to install a simple client library?

To my knowledge Barchart does not have a "npm organization" account ($7 per user, etc).

Additionally, not sure what we are trying to solve (or prevent) with "private" client side packages .... inevitably the JS code is deployed to the world anyway.

@bryaningl3
Copy link
Contributor

bryaningl3 commented Oct 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants