Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support completing-read #5

Merged
merged 8 commits into from
Jan 29, 2021
Merged

feat: support completing-read #5

merged 8 commits into from
Jan 29, 2021

Conversation

bard
Copy link
Owner

@bard bard commented Jan 28, 2021

To try: M-x customize-variable RET run-command-completion-method RET and choose "completing-read".

Fixes: #3

@clemera
Copy link

clemera commented Jan 29, 2021

Thank you! Seems to work fine 👍

@clemera
Copy link

clemera commented Jan 29, 2021

Personally I would default to completing-read, this way ivy and helm will be automatically used when their mode is enabled. Though if you use specific features of them you could check for the mode (at runtime) instead of using featurep. For example I have helm and ivy installed but usually prefer to use default completion with Selectrum.

@bard
Copy link
Owner Author

bard commented Jan 29, 2021 via email

@bard bard merged commit 999e85d into master Jan 29, 2021
@bard
Copy link
Owner Author

bard commented Jan 29, 2021

@clemera merged. Thanks for reporting and for taking the time to test.

@bard bard deleted the completing-read branch January 29, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for default completion via completing-read
2 participants