P2TR support #7
Merged
P2TR support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
octobocto
commented
Nov 23, 2023
octobocto
commented
- proto: add taproot to script types
- src: maybe add taproot support
|
Would love some tests here |
octobocto
force-pushed
the
2023-11-23-taproot
branch
from
a349ec7
to
dea8a08
Compare
octobocto
force-pushed
the
2023-11-23-taproot
branch
from
dea8a08
to
c175305
Compare
octobocto
commented
Nov 23, 2023
| @@ -95,6 +95,7 @@ data class Script(private val script: ScriptType) { | |||
| // operators, and replace this `when` block with something that returns | |||
| // a list of operators. For another day. | |||
| ScriptType.SCRIPT_TYPE_WPKH_NESTED -> "sh(wpkh" | |||
| ScriptType.SCRIPT_TYPE_P2TR -> "p2tr" | |||
There was a problem hiding this comment.
have no idea if this is correct (or how to test it)
octobocto
force-pushed
the
2023-11-23-taproot
branch
from
c175305
to
eb07f23
Compare
|
Test vectors look good, but they're failing |
I'm very sure they're correct, but I think the taproot method is wrong. How can I figure out what operator to call? wrong: also wrong: |
octobocto
force-pushed
the
2023-11-23-taproot
branch
4 times, most recently
from
f302835
to
369eb4a
Compare
torkelrogstad
force-pushed
the
2023-11-23-taproot
branch
from
369eb4a
to
bd17fde
Compare
|
BADABOM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.