feat: improve anotation message #97
Conversation
dist/index.js
Outdated
| @@ -10536,7 +10534,7 @@ const createGithubAccessToken = async (githubAppToken) => { | |||
|
|
|||
| const response = await makeRequest(query, variables); | |||
|
|
|||
| if (!response.data && !response.data.createGithubAccessToken.success) { | |||
| if (!response.data || !response.data.createGithubAccessToken.success) { | |||
There was a problem hiding this comment.
When I execute yarn build, it will contain things that are not my changes.
There was a problem hiding this comment.
let me try to rebuild the master, maybe it was built not with newest version
There was a problem hiding this comment.
everything should be fine now, you should merge with newest master
|
|
||
| const message = `file=${file}::${formattedLines} ${linesWord} not covered with tests`; | ||
|
|
||
| // NOTE: consider an option to show lines directly by attaching 'line' param |
There was a problem hiding this comment.
I don't understand the case of this comment. Under what conditions does it occur?
There was a problem hiding this comment.
I think this is more an issue for Node.js applications coverage reports, mentioned here #40
I think it's great to remove this comment, I will check one more if we can get it fixed before running this action.
There was a problem hiding this comment.
OK. I'll revert back to comment.
|
Looks good, thanks for your contribution! |
recreate #96. I couldn't reopen it because I rebased it.
annotation example
I need help with the two comment places.