Fix: Possible fix for #13 - Node re-creation on the native side #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on each child node tree there's a new recreate method which get's fired everytime something is removed, since react native also removes it's existence from the native side causing re- mounting errors
hack to avoid colliding tags with react native
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 524eb2b:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on each child node tree there's a new recreate method which get's fired everytime something is removed, since
react native also removes it's existence from the native side causing re- mounting errors
fix: #13
Problem with the hack is that it might add quite a large tree of re-creation even something huge is deleted from, for example if the entire screen is re-created in the background, this adds a lot of overhead on the queue and might slow down the app.
The other option is to add
display:noneto the removed node instead of completely removing it from the screen and then enabling the display when anappend/createcall for the same node is made again.