feat: contained router interface #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also separate the cleanup to a separate function
injects scripts for adding an event source connection and handling swapping of the source page by making a new fetch request instead of reloading
also has some improvements for the dom diffing and updates
reimplement kernel with hono
…ng (#2) * created a server class to have a single instance of hono server running * created init and close server in Server class and used them in cli.js * refactor: move logger into a shared util * refactor: contain the server creation and also init logic into the kernel file --------- Co-authored-by: Reaper Gelera <ahoy@barelyhuman.dev>
adds a basic route register that handles the method abstraction which can then be used by kernels to create routes from.
barelyhuman
force-pushed
the
feat/router-abstraction
branch
from
5f06de9
to
fb9fdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the router out of the kernels and into a segregated instance.
Also implement a context mapper to be able to unify how prev works with different kernels