created a server class to have a single instance of hono server running #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, you could however move the entire init and close also in the kernel/hono.js then instead of having them in Example it'll just be server.init() and server.close() in the cli.js and the kernel.js handles the creation and shutting down for you |
Shofiya2003
commented
May 18, 2023
prev/cli.js
Outdated
| @@ -288,22 +271,9 @@ function normalizeConfig(config) { | |||
|
|
|||
| async function queueRestart() { | |||
| const mod = await import('./kernel/index.js') | |||
There was a problem hiding this comment.
Should I remove direct import from here and add getServer function in config?
|
So, the init phase was just supposed to be for initialising the server start and listening phase, the cli's original intention was to stay as is. I'll add the modifications once I'm done with the other to help understand |
and also init logic into the kernel file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel restart led to
EADDRINUSEerror. Solved this issue using singleton server, created a Server class to have a single instance of hono server running at a time. Addedinitandclosefunction to the class.