This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
PostgreSQL and MySQL compatibility. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table- and column-names are now passed into the SelectObject by a helper function, which converts the string to lower-case e.g. for PostgreSQL or leaves it camel-case for MySQL, so we don't need to repeat most of the code for different databases, as identifiers might be different depending on which database you use. This is a workaround for an inconsistence in the Bareos installation scripts relating the creation of needed database tables for the catalogue. The helper function strdbcompat() might also be extended in future for Oracle databases, where identifiers are handled upper-case by default and possible other databases.
fbergkemper
pushed a commit
that referenced
this pull request
Jul 30, 2014
PostgreSQL and MySQL compatibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table- and column-names are now passed into the SelectObject by a helper function, which
converts the string to lower-case e.g. for PostgreSQL or leaves it camel-case for MySQL,
so we don't need to repeat most of the code for different databases, as identifiers might
be different depending on which database you use. This is a workaround for an inconsistence
in the Bareos installation scripts relating the creation of needed database tables for
the catalogue. The helper function strdbcompat() might also be extended in future for Oracle
databases, where identifiers are handled upper-case by default and possible other databases.