Implement OPTIONS ping #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
options_ping
branch
2 times, most recently
from
1df038e
to
6b6ebb3
Compare
A module that implements a pinging mechanism using SIP OPTIONS to qualify the peer while a call is in the INCOMING state to ensure that the peer is reachable and we will be able to successfully answer the call.
cspiel1
reviewed
Oct 18, 2023
modules/qualify/qualify.c
Outdated
| * peer while a call is in the INCOMING state to ensure that the peer is | ||
| * reachable and we will be able to successfully answer the call. | ||
| * | ||
| * Configuration: |
There was a problem hiding this comment.
Instead of "Configuration:" write "Configure in address parameter extra:"
And combine with the example below. Maybe both at the end?
cspiel1
reviewed
Oct 18, 2023
modules/qualify/qualify.c
Outdated
| * The OPTIONS are only sent if both options are present, both are not zero, | ||
| * qualify_freq is greater than qual_to, and the call is incoming. As soon as | ||
| * the call is established or closed, we stop sending OPTIONS. | ||
| * If we run don’t receive a response to an OPTIONS request within the |
There was a problem hiding this comment.
- correct this sentence
- Avoid "we"! Use the local UA, or "is stopped", "is sent"!
maximilianfridrich
force-pushed
the
options_ping
branch
from
6b6ebb3
to
2820008
Compare
maximilianfridrich
force-pushed
the
options_ping
branch
from
2e9e7a7
to
b0bc06c
Compare
cspiel1
reviewed
Oct 18, 2023
modules/qualify/qualify.c
Outdated
| if (!qualle->offline) { | ||
| qualle->offline = true; | ||
| ua_event(call_get_ua(call), UA_EVENT_CUSTOM, call, | ||
| "Peer offline"); |
There was a problem hiding this comment.
Please use module_event()! General in this module!
modules/qualify/qualify.c
Outdated
| } | ||
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Doxygen @param missing.
Better drop this. Its static and the return codes are not used.
Return codes are not standard codes.
maximilianfridrich
force-pushed
the
options_ping
branch
3 times, most recently
from
61a2630
to
8091431
Compare
maximilianfridrich
force-pushed
the
options_ping
branch
from
8091431
to
8580bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qualify: add qualify module
This module implements a pinging mechanism using SIP OPTIONS to qualify the peer while a call is in the INCOMING state to ensure that the peer is reachable and we will be able to successfully answer the call.
Configuration:
The OPTIONS are only sent if both options are present, both are not zero,
qual_intis greater thanqual_to, and the call is incoming. As soon as the call is established or closed, we stop sending OPTIONS. If we run don’t receive a response to an OPTIONS request within the specifiedqual_to, the call is terminated andUA_EVENT_CALL_CLOSEDis triggered.Extra account address parameters:
The module can be activated by adding both the
qual_intand thequal_toparameters to the accounts parameterextra.Example:
Related: