qualify: fix OPTIONS refcounting #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspiel1
reviewed
Dec 15, 2023
modules/qualify/qualify.c
Outdated
|
|
||
| if (closed) | ||
| if (closed) { |
There was a problem hiding this comment.
This function has two different purposes.
I suggest to remove closed parameter and move the branch to the switch under UA_EVENT_CALL_CLOSED
There was a problem hiding this comment.
Refactored.
maximilianfridrich
force-pushed
the
options_fix
branch
2 times, most recently
from
07fa585
to
c388521
Compare
maximilianfridrich
force-pushed
the
options_fix
branch
from
c388521
to
3dd4c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.