Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-conditional and wrong standard RPATHs break building on Fedora #2849

Closed
robert-scheck opened this issue Dec 28, 2023 · 3 comments
Closed

Non-conditional and wrong standard RPATHs break building on Fedora #2849

robert-scheck opened this issue Dec 28, 2023 · 3 comments

Comments

@robert-scheck
Copy link
Collaborator

robert-scheck commented Dec 28, 2023 •
edited

Unfortunately, commits d46df52 and 38f7823 (related to #2831, #2837 and #2839) break building baresip on Fedora, because it introduces non-conditional and wrong standard RPATHs:

Practically, RPATH should only be set if the library path does not match the default library path. In this case, a (64 bit) ELF binary in /usr/bin or /usr/lib64 even as a RPATH to (32 bit) /usr/lib:

ERROR   0001: file '/usr/lib64/libbaresip.so.12.8.0' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/x11.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/stun.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/evdev.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/account.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/stdio.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/turn.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/aubridge.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/uuid.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/bin/baresip' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/auconv.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/vidbridge.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/aufile.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/vidinfo.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/auresamp.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/vumeter.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/ausine.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/aac.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/cons.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/alsa.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/contact.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/av1.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/ctrl_tcp.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/codec2.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/debug_cmd.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/ctrl_dbus.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/ebuacip.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/gst.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/echo.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/gtk.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/fakevideo.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/dtls_srtp.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/g711.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/jack.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/httpd.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/mpa.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/httpreq.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/mqtt.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/ice.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/opus.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/l16.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/opus_multistream.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/menu.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/snapshot.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/mixausrc.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/portaudio.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/mixminus.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/pulse.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/multicast.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/pipewire.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/mwi.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/sdl.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/natpmp.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/sndfile.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/netroam.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/syslog.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/pcp.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/presence.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/g722.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/g726.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/rtcpsummary.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/plc.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/selfview.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/serreg.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/v4l2.so' contains a standard runpath '/usr/lib' in [/usr/lib]
ERROR   0001: file '/usr/lib64/baresip/modules/vp8.so' contains a standard runpath '/usr/lib' in [/usr/lib]
@alfredh
Copy link
Collaborator

alfredh commented Dec 28, 2023

Is it possible to add a Fedora CI job, so we can avoid this in the future ?

@robert-scheck
Copy link
Collaborator Author

Is it possible to add a Fedora CI job, so we can avoid this in the future ?

Yes, I think that's possible. I am happy to work on this, but at earliest at the end of next week. Matches something like .github/workflows/fedora.yml at re (but with Fedora's /usr/lib/rpm/check-rpaths) your intention?

sreimers pushed a commit that referenced this issue Jan 2, 2024
@robert-scheck @sreimers
cmake: add only non-system link paths to rpath (fixes #2849) (#2850)
f4590fe
@robert-scheck robert-scheck mentioned this issue Feb 3, 2024
Merged
@robert-scheck
Copy link
Collaborator Author

Is it possible to add a Fedora CI job, so we can avoid this in the future ?

Finally…suggested with #2904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfredh @robert-scheck