Patch for cross-compiling #1

fadeevab · 2014-02-10T13:51:56Z

For cross-compiling of baresip I used the next directory structure:
./re
./rem
./baresip

So, I cross-compiled with next commands in my custom Makefile:
Cross-compile "re"

. some-arm-env-setup; cd re; make SYSROOT=$(TARGET_FSROOT)/usr PREFIX=$(TARGET_FSROOT)/usr/local
Cross-compile "rem"

. some-arm-env-setup; cd rem; make SYSROOT=$(TARGET_FSROOT)/usr PREFIX=$(TARGET_FSROOT)/usr/local LIBRE_INC=../re/include
Cross-compile "baresip"

. some-arm-env-setup; cd baresip; make SYSROOT=$(TARGET_FSROOT)/usr DESTDIR=$(TARGET_FSROOT) PREFIX=/usr/local LIBRE_INC=../re/include

In short, I used SYSROOT, PREFIX, DESTDIR and LIBRE_INC... And this patch fixes using of SYSROOT for baresip.

alfredh · 2014-02-12T15:47:43Z

thank you for this patch, I have committed half the patch (Makefile).

I am not sure if $(LIBS) is needed in linking of all modules. The idea is that
each module should only link to the modules that it is using. Is the problem
that your linked cannot find libre.so? try to set the LIBRE_SO variable when
invoking make, and point it to the path where your libre.so file is.

fadeevab · 2014-02-13T11:00:42Z

No, no, the problem is that system libraries for modules (avcodec, speex, cairo and other) is in ./some/filesystem/usr/lib directory, and this directory doesn't take place nowhere... So, I have to specify -L(SYSROOT)/lib for each module, or in common script for all modules. What way is better?

alfredh · 2014-02-13T13:22:03Z

we have two make variables that can be used: $(LFLAGS) and $(LIBS)

ideally the idea was that LFLAGS contains all linker flags, and LIBS contain
a list of all the libraries that you link to.

so it might be better to use LFLAGS for the extra -L$(SYSROOT)/lib info?

mk/mod.mk already contains $(LFLAGS) on the linker stage, so I think all we have
to do is to add your -LSYSROOT to FLAGS in the top-level Makefile ..

(note: the makefile buildsystem is not perfect and might need some cleanup or
refactoring at some point :)

fadeevab · 2014-02-13T15:14:52Z

"Not perfect" build system is diabolic autoconf and etc, and your system is pretty much better :D But never mind... I'll try LFLAGS and tell you about results.

singalen · 2014-02-25T12:19:12Z

Now we know thaer half of the patch was due garbage on Alex's system, so we can definitely close this one.

Upstream

found with Coverity Scan: if (!player->thr.run) { 345 int err; 346 347 player->thr.run = true; 348 err = pthread_create(&player->thr.tid, NULL, 349 rx_thread, player); 4. Condition err, taking true branch. 350 if (err) { 351 player->thr.run = false; CID 331124 (#1 of 1): Missing unlock (LOCK) 5. missing_unlock: Returning without unlocking player->thr.mutex. 352 return; 353 } 354 } 355 356 pthread_cond_signal(&player->thr.cond); 357 pthread_mutex_unlock(&player->thr.mutex);

* multicast: fix missing unlock found with Coverity Scan: if (!player->thr.run) { 345 int err; 346 347 player->thr.run = true; 348 err = pthread_create(&player->thr.tid, NULL, 349 rx_thread, player); 4. Condition err, taking true branch. 350 if (err) { 351 player->thr.run = false; CID 331124 (#1 of 1): Missing unlock (LOCK) 5. missing_unlock: Returning without unlocking player->thr.mutex. 352 return; 353 } 354 } 355 356 pthread_cond_signal(&player->thr.cond); 357 pthread_mutex_unlock(&player->thr.mutex); * fix formatting

CID 333030 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 2. fixed_size_dest: You might overrun the 9-character fixed-size string buf by copying the return value of sip_transp_name without checking the length.

Fixes: WARNING: ThreadSanitizer: data race (pid=298819) Write of size 1 at 0x7b68000013c8 by main thread (mutexes: write M1592): #0 aurx_stream_decode /baresip/src/audio.c:1089:20 (baresip+0x1263e5) #1 stream_recv_handler /baresip/src/audio.c:1195:8 (baresip+0x11ef36) Previous read of size 1 at 0x7b68000013c8 by thread T1 (mutexes: write M1569): #0 auplay_write_handler /baresip/src/audio.c:703:10 (baresip+0x125236) Location is heap block of size 1504 at 0x7b6800001200 allocated by main thread: #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29b9df) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29be85) #3 audio_alloc /baresip/src/audio.c:1270:6 (baresip+0x11d1f7)

WARNING: ThreadSanitizer: data race (pid=18337) Write of size 1 at 0x7b6800001368 by main thread (mutexes: write M1592, write M1580): #0 stop_tx /baresip/src/audio.c:285:16 (baresip+0x1206a0) #1 audio_stop /baresip/src/audio.c:1888:2 (baresip+0x1205ad) Previous read of size 1 at 0x7b6800001368 by thread T2: #0 tx_thread /baresip/src/audio.c:1445:16 (baresip+0x125a97) Location is heap block of size 1512 at 0x7b6800001200 allocated by main thread: #0 malloc <null> (baresip+0x8e19e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29a86f) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29ad15) #3 audio_alloc /baresip/src/audio.c:1276:6 (baresip+0x11c1e7)

Fixes: WARNING: ThreadSanitizer: data race (pid=298819) Write of size 1 at 0x7b68000013c8 by main thread (mutexes: write M1592): #0 aurx_stream_decode /baresip/src/audio.c:1089:20 (baresip+0x1263e5) #1 stream_recv_handler /baresip/src/audio.c:1195:8 (baresip+0x11ef36) Previous read of size 1 at 0x7b68000013c8 by thread T1 (mutexes: write M1569): #0 auplay_write_handler /baresip/src/audio.c:703:10 (baresip+0x125236) Location is heap block of size 1504 at 0x7b6800001200 allocated by main thread: #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29b9df) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29be85) #3 audio_alloc /baresip/src/audio.c:1270:6 (baresip+0x11d1f7)

WARNING: ThreadSanitizer: data race (pid=18337) Write of size 1 at 0x7b6800001368 by main thread (mutexes: write M1592, write M1580): #0 stop_tx /baresip/src/audio.c:285:16 (baresip+0x1206a0) #1 audio_stop /baresip/src/audio.c:1888:2 (baresip+0x1205ad) Previous read of size 1 at 0x7b6800001368 by thread T2: #0 tx_thread /baresip/src/audio.c:1445:16 (baresip+0x125a97) Location is heap block of size 1512 at 0x7b6800001200 allocated by main thread: #0 malloc <null> (baresip+0x8e19e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29a86f) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29ad15) #3 audio_alloc /baresip/src/audio.c:1276:6 (baresip+0x11c1e7)

Fixes: WARNING: ThreadSanitizer: data race (pid=298819) Write of size 1 at 0x7b68000013c8 by main thread (mutexes: write M1592): #0 aurx_stream_decode /baresip/src/audio.c:1089:20 (baresip+0x1263e5) #1 stream_recv_handler /baresip/src/audio.c:1195:8 (baresip+0x11ef36) Previous read of size 1 at 0x7b68000013c8 by thread T1 (mutexes: write M1569): #0 auplay_write_handler /baresip/src/audio.c:703:10 (baresip+0x125236) Location is heap block of size 1504 at 0x7b6800001200 allocated by main thread: #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29b9df) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29be85) #3 audio_alloc /baresip/src/audio.c:1270:6 (baresip+0x11d1f7)

WARNING: ThreadSanitizer: data race (pid=18337) Write of size 1 at 0x7b6800001368 by main thread (mutexes: write M1592, write M1580): #0 stop_tx /baresip/src/audio.c:285:16 (baresip+0x1206a0) #1 audio_stop /baresip/src/audio.c:1888:2 (baresip+0x1205ad) Previous read of size 1 at 0x7b6800001368 by thread T2: #0 tx_thread /baresip/src/audio.c:1445:16 (baresip+0x125a97) Location is heap block of size 1512 at 0x7b6800001200 allocated by main thread: #0 malloc <null> (baresip+0x8e19e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29a86f) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29ad15) #3 audio_alloc /baresip/src/audio.c:1276:6 (baresip+0x11c1e7)

Fixes: WARNING: ThreadSanitizer: data race (pid=298819) Write of size 1 at 0x7b68000013c8 by main thread (mutexes: write M1592): #0 aurx_stream_decode /baresip/src/audio.c:1089:20 (baresip+0x1263e5) #1 stream_recv_handler /baresip/src/audio.c:1195:8 (baresip+0x11ef36) Previous read of size 1 at 0x7b68000013c8 by thread T1 (mutexes: write M1569): #0 auplay_write_handler /baresip/src/audio.c:703:10 (baresip+0x125236) Location is heap block of size 1504 at 0x7b6800001200 allocated by main thread: #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29b9df) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29be85) #3 audio_alloc /baresip/src/audio.c:1270:6 (baresip+0x11d1f7)

WARNING: ThreadSanitizer: data race (pid=18337) Write of size 1 at 0x7b6800001368 by main thread (mutexes: write M1592, write M1580): #0 stop_tx /baresip/src/audio.c:285:16 (baresip+0x1206a0) #1 audio_stop /baresip/src/audio.c:1888:2 (baresip+0x1205ad) Previous read of size 1 at 0x7b6800001368 by thread T2: #0 tx_thread /baresip/src/audio.c:1445:16 (baresip+0x125a97) Location is heap block of size 1512 at 0x7b6800001200 allocated by main thread: #0 malloc <null> (baresip+0x8e19e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x29a86f) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x29ad15) #3 audio_alloc /baresip/src/audio.c:1276:6 (baresip+0x11c1e7)

WARNING: ThreadSanitizer: data race (pid=59549) Read of size 8 at 0x7b3800003ed8 by thread T2 (mutexes: read M1643): #0 aubuf_cur_size /rem/src/aubuf/aubuf.c:392:11 (baresip+0x205044) #1 ausrc_read_handler /baresip/src/audio.c:886:6 (baresip+0x11d6ac) #2 read_thread /baresip/modules/alsa/alsa_src.c:88:3 (baresip+0x16a193) Previous write of size 8 at 0x7b3800003ed8 by main thread (mutexes: write M1554): #0 memset <null> (baresip+0xcc85d) #1 mem_zalloc /re/src/mem/mem.c:178:2 (baresip+0x1f4273) #2 aubuf_alloc /rem/src/aubuf/aubuf.c:78:7 (baresip+0x20453a) #3 start_source /baresip/src/audio.c:1756:10 (baresip+0x11bb77) #4 audio_start /baresip/src/audio.c:1823:9 (baresip+0x11b148) #5 audio_encoder_set /baresip/src/audio.c:1982:10 (baresip+0x11c44b) #6 start_audio /baresip/src/call.c:146:10 (baresip+0x126b01) #7 menc_event_handler /baresip/src/call.c:488:10 (baresip+0x121f10) #8 dtls_estab_handler /baresip/modules/dtls_srtp/dtls_srtp.c:269:4 (baresip+0x17545a) #9 conn_recv /re/src/tls/openssl/tls_udp.c:402:4 (baresip+0x1e819d) #10 recv_handler /re/src/tls/openssl/tls_udp.c:772:3 (baresip+0x1e819d) #11 udp_read /re/src/udp/udp.c:237:10 (baresip+0x1debc5) #12 udp_read_handler /re/src/udp/udp.c:255:2 (baresip+0x1de541) #13 fd_poll /re/src/main/main.c:885:4 (baresip+0x1f2fe6) #14 re_main /re/src/main/main.c:1023:9 (baresip+0x1f2fe6) #15 main /baresip/src/main.c:299:8 (baresip+0x145524) Location is heap block of size 216 at 0x7b3800003e20 allocated by main thread: #0 malloc <null> (baresip+0x8f12e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x1f409d) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x1f425e) #3 aubuf_alloc /rem/src/aubuf/aubuf.c:78:7 (baresip+0x20453a) #4 start_source /baresip/src/audio.c:1756:10 (baresip+0x11bb77) #5 audio_start /baresip/src/audio.c:1823:9 (baresip+0x11b148) #6 audio_encoder_set /baresip/src/audio.c:1982:10 (baresip+0x11c44b) #7 start_audio /baresip/src/call.c:146:10 (baresip+0x126b01) #8 menc_event_handler /baresip/src/call.c:488:10 (baresip+0x121f10)

* audio: allocate aubuf before ausrc_alloc (fixes data race) WARNING: ThreadSanitizer: data race (pid=59549) Read of size 8 at 0x7b3800003ed8 by thread T2 (mutexes: read M1643): #0 aubuf_cur_size /rem/src/aubuf/aubuf.c:392:11 (baresip+0x205044) #1 ausrc_read_handler /baresip/src/audio.c:886:6 (baresip+0x11d6ac) #2 read_thread /baresip/modules/alsa/alsa_src.c:88:3 (baresip+0x16a193) Previous write of size 8 at 0x7b3800003ed8 by main thread (mutexes: write M1554): #0 memset <null> (baresip+0xcc85d) #1 mem_zalloc /re/src/mem/mem.c:178:2 (baresip+0x1f4273) #2 aubuf_alloc /rem/src/aubuf/aubuf.c:78:7 (baresip+0x20453a) #3 start_source /baresip/src/audio.c:1756:10 (baresip+0x11bb77) #4 audio_start /baresip/src/audio.c:1823:9 (baresip+0x11b148) #5 audio_encoder_set /baresip/src/audio.c:1982:10 (baresip+0x11c44b) #6 start_audio /baresip/src/call.c:146:10 (baresip+0x126b01) #7 menc_event_handler /baresip/src/call.c:488:10 (baresip+0x121f10) #8 dtls_estab_handler /baresip/modules/dtls_srtp/dtls_srtp.c:269:4 (baresip+0x17545a) #9 conn_recv /re/src/tls/openssl/tls_udp.c:402:4 (baresip+0x1e819d) #10 recv_handler /re/src/tls/openssl/tls_udp.c:772:3 (baresip+0x1e819d) #11 udp_read /re/src/udp/udp.c:237:10 (baresip+0x1debc5) #12 udp_read_handler /re/src/udp/udp.c:255:2 (baresip+0x1de541) #13 fd_poll /re/src/main/main.c:885:4 (baresip+0x1f2fe6) #14 re_main /re/src/main/main.c:1023:9 (baresip+0x1f2fe6) #15 main /baresip/src/main.c:299:8 (baresip+0x145524) Location is heap block of size 216 at 0x7b3800003e20 allocated by main thread: #0 malloc <null> (baresip+0x8f12e) #1 mem_alloc /re/src/mem/mem.c:141:6 (baresip+0x1f409d) #2 mem_zalloc /re/src/mem/mem.c:174:6 (baresip+0x1f425e) #3 aubuf_alloc /rem/src/aubuf/aubuf.c:78:7 (baresip+0x20453a) #4 start_source /baresip/src/audio.c:1756:10 (baresip+0x11bb77) #5 audio_start /baresip/src/audio.c:1823:9 (baresip+0x11b148) #6 audio_encoder_set /baresip/src/audio.c:1982:10 (baresip+0x11c44b) #7 start_audio /baresip/src/call.c:146:10 (baresip+0x126b01) #8 menc_event_handler /baresip/src/call.c:488:10 (baresip+0x121f10) * audio: recalculate and resize aubuf if necessary * fix ausrc_prm setting * ausrc_prm needs to be set before ausrc_alloc too * fix newline * audio/start_source: allow prm format changes

Patch for cross-compiling

e498771

alfredh closed this Jun 25, 2014

alfredh pushed a commit that referenced this pull request Nov 2, 2014

Merge pull request #1 from alfredh/master

ac29f91

Upstream

ishmaelen mentioned this pull request Dec 8, 2016

GStreamer 1.4.5 #171

Closed

FessAectan mentioned this pull request May 3, 2017

Core dumped when I try making call via httpd module. #238

Closed

stephenvharvey mentioned this pull request Jul 25, 2017

No video frames from H.264 USB camera using v4l2_codec with baresip to baresip #283

Closed

RaghuSip mentioned this pull request Aug 15, 2017

build fails - snd_htimestamp_t - asoundlib #154

Closed

kemotz mentioned this pull request Oct 4, 2017

avformat.so: undefined symbol: av_buffersink_get_time_base #308

Closed

bboelaert mentioned this pull request Nov 10, 2017

v4l2: v4l2loopback hangs on disconnect #321

Closed

micmac1 mentioned this pull request May 12, 2018

baresip: different hashes between the github and website releases #388

Closed

mk6032 mentioned this pull request Jun 7, 2018

baresip-0.5.9 compile fails armv6 #421

Closed

ondralie mentioned this pull request Jul 12, 2019

I can dial number but I dont know about incoming call #751

Closed

webstean mentioned this pull request Oct 22, 2019

Segmentation fault on running latest on Raspberry Pi #827

Closed

juha-h mentioned this pull request Apr 6, 2020

auframe: add timestamp #956

Merged

16 tasks

webstean mentioned this pull request Aug 11, 2020

failed to self-sign certificate (Cannot allocate memory) #1056

Closed

phil-lavin mentioned this pull request Apr 27, 2021

alsa: could not open auplay device xxx (Device or resource busy) when enable menu.so module #808

Closed

This was referenced May 1, 2021

segmentation fault for /config #1419

Closed

Multiple dial commands with short delay and aufile source causes a core dump #1427

Closed

negbie mentioned this pull request May 14, 2021

Segmentation fault on /line without argument #1448

Closed

jbittner1002 mentioned this pull request May 24, 2021

segfault #1467

Closed

This was referenced Aug 2, 2021

multicast: fix missing unlock #1559

Merged

config: replace strcpy by saver re_snprintf (#1558) #1560

Merged

JuanPascual2 mentioned this pull request Feb 21, 2022

Segmentation fault (core dumped) #1727

Closed

sreimers mentioned this pull request Feb 28, 2022

audio: allocate aubuf before ausrc_alloc (fixes data race) #1748

Merged

sreimers mentioned this pull request Jul 24, 2022

call: fix heap-buffer-overflow in prack_handler #1988

Merged

braathwaate mentioned this pull request Nov 1, 2022

floating point exception with /ausrc aufile #2293

Closed

copiltembel mentioned this pull request May 28, 2023

tls: accept error: no shared cipher #2592

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch for cross-compiling #1

Patch for cross-compiling #1

fadeevab commented Feb 10, 2014

alfredh commented Feb 12, 2014

fadeevab commented Feb 13, 2014

alfredh commented Feb 13, 2014

fadeevab commented Feb 13, 2014

singalen commented Feb 25, 2014

Patch for cross-compiling #1

Patch for cross-compiling #1

Conversation

fadeevab commented Feb 10, 2014

alfredh commented Feb 12, 2014

fadeevab commented Feb 13, 2014

alfredh commented Feb 13, 2014

fadeevab commented Feb 13, 2014

singalen commented Feb 25, 2014