call: never set sent_answer to false #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is true if any SDP answer was already sent to the peer. It is used in static_menu.c to decide if the `ldir` has to be set or not. After sending the first SDP answer `ldir` should stay unchanged at the value that was used during encoding the SDP answer. It is important for call_need_modify() to decide if a re-INVITE is needed or not. That's why sent_answer should not be reset to false. This could lead to a missing re-INVITE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is true if any SDP answer was already sent to the peer. It is used
in static_menu.c to decide if the
ldirhas to be set or not. After sendingthe first SDP answer
ldirshould stay unchanged at the value that was usedduring encoding the SDP answer. It is important for call_need_modify() to
decide if a re-INVITE is needed or not. That's why sent_answer should not be
reset to false. This could lead to a missing re-INVITE.