avcodec/decode: refactor hw_frame handling #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With hardware decoding I had crashes after av_hwframe_transfer_data. It looks like a fresh frame is needed and can not be reused with some hardware codecs.
sreimers
changed the title
alfredh
reviewed
Sep 17, 2023
| frame->data[i] = st->pict->data[i]; | ||
| frame->linesize[i] = st->pict->linesize[i]; | ||
| frame->data[i] = sw_frame->data[i]; | ||
| frame->linesize[i] = sw_frame->linesize[i]; |
There was a problem hiding this comment.
please note that the frame memory has to be available after this function has returned,
because the vidframe is point to those data buffers ...
There was a problem hiding this comment.
av_free should only free the allocated AVFrame struct not the data itself I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With hardware decoding I had crashes after
av_hwframe_transfer_data. It looks like a cleandstframe is needed and can not be reused with some hardware codecs.