Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: jbuf plots #2733

Merged
merged 7 commits into from
Sep 27, 2023
Merged

tools: jbuf plots #2733

merged 7 commits into from
Sep 27, 2023

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Sep 27, 2023

  • tools: add jbuf plot tools
  • tools: add jbuf audio call plots
  • tools: jbuf support png plots
  • tools: jbuf add README.md
  • tools: jbuf README.md add note about units
  • tools: jbuf typo in jbuf.plot
  • tools: jbuf README.md add note about peer

@cspiel1 cspiel1 mentioned this pull request Sep 27, 2023
Closed
3 tasks
@cspiel1
tools: jbuf plots - no pipe for jq
35d4e84
@cspiel1
Revert "tools: jbuf plots - no pipe for jq"
8d3d599 
This reverts commit 35d4e84.

Because of
```
 jq: error: Could not open file jbuf.json: Permission denied
```
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Sep 27, 2023 •
edited

Some Results

Note: Underflows like counted here are not really a problem. Real underflows of the decoder can't be counted in jbuf so far.

Video with jbuf adaptive 0-500

jbuf_video_0

Video with jbuf fixed 2-500

jbuf_video_2

@cspiel1 cspiel1 marked this pull request as ready for review September 27, 2023 11:54
@sreimers
Copy link
Member

Note: Underflows like counted here are not really a problem. Real underflows of the decoder can't be counted in jbuf so far.

Yes, waiting or something like this would be better. But's fine for now. We can optimize wording after refactoring.

sreimers
sreimers reviewed Sep 27, 2023
View reviewed changes
tools/jbuf/README.md Outdated Show resolved Hide resolved
sreimers
sreimers reviewed Sep 27, 2023
View reviewed changes
tools/jbuf/jbuf.plot Outdated Show resolved Hide resolved
@sreimers sreimers changed the title jbuf plots tools: jbuf plots Sep 27, 2023
@sreimers sreimers merged commit 53c2560 into baresip:main Sep 27, 2023
17 checks passed
@cspiel1 cspiel1 deleted the jbuf_plots branch September 27, 2023 12:56
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Sep 27, 2023

Thanks! Please also merge the related PR baresip/re#964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreimers sreimers sreimers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cspiel1 @sreimers