test: call - add call on-hold/resume test

[cspiel1]

relates to: baresip/re#990
try to reproduce: #2772

• adds call on hold and resume test
• adds function to wait for SIP ACK

[cspiel1]

I added a function to re: baresip/re#990

Does someone have a better idea?

[cspiel1]

The last commit replaces ACK check from UA a to b. Because b sends the SIP Reply also b has to wait for the ACK.

Now the ACK check fails because it was not received during re_main. A reason could be that the loop was canceled to early.

[cspiel1]

For a correct cancel rule that waits for an ACK maybe we need an event/callback function. Maybe the new getter function is not enough. I have to think if we can avoid this.

[cspiel1]

@sreimers do you have a better idea to implement a wait for ACK?

• At least we should avoid the timeout warnings somehow.
• The last commit also adds an ugly sleep of 1ms.

[cspiel1]

re-based to main HEAD after merge of 33047e6

[sreimers]

@sreimers do you have a better idea to implement a wait for ACK?

• At least we should avoid the timeout warnings somehow.
• The last commit also adds an ugly sleep of 1ms.

Not sure if I understand all details of the problem, is it maybe possible to add/register or reuse any callback instead of the active wait loop?

edit: Ah I see, you suggested something similar already.

[cspiel1]

Not sure if I understand all details of the problem, is it maybe possible to add/register or reuse any callback instead of the active wait loop?

edit: Ah I see, you suggested something similar already.

Yes, but as we know another callback increases the complexity. Currently there is no callback that can be used. Except if we put an SDP into the ACK. This would test something different, a special case where the offer is contained in the SIP reply and the answer in the ACK, if I understood ack_handler() in listen.c correctly.

[sreimers]

Maybe a active tmr callback works better in this case, it's not perfect but should prevent timeout warnings.

[cspiel1]

I tried to add an sipsess_ack_h callback. This is too much only for unit tests. BTW: Found that we have a redundant use of call->arg. It can be overwritten by ABI function call_set_handlers().

The timer is a good idea for checking the ACK.

[alfredh]

Thanks for writing this test. This looks like a good addition :)

[cspiel1]

Your welcome! In following PRs we could add the wait for ACK condition to more tests. Maybe other re-INVITE tests.

[alfredh]

please resolve the conflicts ..

[cspiel1]

This is ready to merge from my side. Any more suggestions?