test/call.c: extend test_call_hold_resume #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
mdir_tests
branch
from
7c456a2
to
f6d1514
Compare
maximilianfridrich
changed the title
maximilianfridrich
force-pushed
the
mdir_tests
branch
from
f6d1514
to
f628cd2
Compare
|
Looks good to me. |
|
In a future PR we should make the counter |
|
This test became unstable after the merge: https://github.com/baresip/baresip/actions/runs/6783024753/job/18436437302 can you please investigate ? |
|
@alfredh I'm not sure if I'm interpreting the linked output correctly, but it looks like it found a data race when running |
|
I will have a look. |
This #2809 should directly solve the sanitizer warning. |
maximilianfridrich
added a commit
to maximilianfridrich/baresip
that referenced
this pull request
Dec 18, 2023
(cherry picked from commit 305d0bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
test_call_hold_resumetest by initiating a call and offering the streams assendonly. The test verifies that this does not trigger anUA_EVENT_CALL_HOLDon the receiving side of this offer. It then does a few hold/resumes from both sides and verifies the eventsUA_EVENT_CALL_HOLDandUA_EVENT_CALL_RESUMEare only triggered when they should.