audio: fix inbound dtmf END event #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- call `stream_pt_handler()` always - `stream_pt_handler()` in audio and video have a lightweight check at top - NULL pointer check of audio.rx is not needed
cspiel1
force-pushed
the
audio_inbound_dtmf_end
branch
from
c044313
to
981213c
Compare
cspiel1
commented
Nov 10, 2023
| handle_telev(a, mb); | ||
| return ENODATA; | ||
| } | ||
|
|
||
| if (!lc) | ||
| return ENOENT; | ||
|
|
||
| if (rx->pt == pt) |
There was a problem hiding this comment.
This check is not needed. But helps to validate that decoder is not set more than once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DTMF END is missing when registered to Asterisk.
Asterisk sends less RTP EVENT packets than baresip and does not mix audio RTP packets and DTMF packets like baresip. If the "DTMF end" follows directly a normal DTMF packet than it was not recognized.
stream_pt_handler()alwaysstream_pt_handler()in audio and video have a lightweight check at topAlternative check with less lines, but more difficult to read:
Does somebody prefer the shorter check?