Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbuf: fix memory leak in jbuf_debug() #2813

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Nov 22, 2023

No description provided.

@cspiel1 cspiel1 added this to the v3.7.0 milestone Nov 22, 2023
@cspiel1 cspiel1 merged commit 2e9c7bf into baresip:main Nov 22, 2023
16 checks passed
@cspiel1 cspiel1 deleted the jbuf_mem_leak branch November 22, 2023 08:28

if (!jb)
return 0;

struct mbuf *mb = mbuf_alloc(512);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should null check mb here too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, your right. I'll make another PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #2814

maximilianfridrich pushed a commit to maximilianfridrich/baresip that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants