Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu: an incoming call should not change the current call #2869

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Jan 10, 2024

Additionally, the ringtone is only started for the first incoming call.
The ringtone is not stopped if another call is incoming.

If there are multiple incoming calls, then the first incoming call is answered with command accept by default.

Current behavior in main: The last incoming call is answered.

Additionally, the ringtone is only started for the first incoming call.
The ringtone is not stopped if another call is incoming.
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Jan 10, 2024

@alfredh you wrote once into call.c

/* NOTE: The new call must always be added to the tail of list,
 *       which indicates the current call.
 */
 list_append(lst, &call->le, call);

Is this still wanted? Or should we re-define the head of the list as current call?
As a workaround I added to menu.c in this PR:

menu_selcall(menu.curcall);

@juha-h If there are multiple incoming calls at the Android baresip app, which one is shown on the screen? The first one or the last one?

@juha-h
Copy link
Collaborator

juha-h commented Jan 10, 2024

My Android app does not currently support multiple calls except during call transfer. If a call comes in and there already exists a call, the app responds with 486 Busy.

@alfredh alfredh merged commit 87c4ecd into baresip:main Jan 11, 2024
16 checks passed
@alfredh
Copy link
Collaborator

alfredh commented Jan 11, 2024

the tail is used to indicate current call.

This logic could be changed or improved, if you think it is faulty ...

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Jan 11, 2024

the tail is used to indicate current call.

This logic could be changed or improved, if you think it is faulty ...

Okay, I will think about this.

@cspiel1 cspiel1 deleted the menu_incoming_calls branch January 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants