Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account: read catchall flag from accounts file #2925

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Feb 16, 2024

No description provided.

src/account.c Outdated
*
* @return 0 if success, otherwise errorcode
*/
int account_set_catchall(struct account *acc, bool value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it is better to return void here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that there are many similar functions that return EINVAL only for acc==NULL.

@sreimers sreimers added this to the v3.11.0 milestone Mar 5, 2024
@sreimers sreimers merged commit a2468cf into baresip:main Mar 6, 2024
18 checks passed
@cspiel1 cspiel1 deleted the accounts_catchall_flag branch March 11, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants