sndfile: write correct sample rate to WAV header #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The decoder and filter should be set based on the codec negotiated in SDP. When the first incoming RTP packet arrives, it will check the payload-type and possibly reset the decoder. So I am not sure if this change is really needed. |
|
The sample rate can change if e.g. |
When the update functions are called the sample rate and format can't be predicted. Thus the header has to be written when the first audio frame reaches the filter.
cspiel1
force-pushed
the
sndfile_correct_header
branch
from
acbf542
to
a2d75f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the update functions are called the sample rate and format can't be
predicted. Thus the header has to be written when the first audio frame reaches
the filter.
Issue mentioned here: #2938 (comment)