test: add usage of rtcp_msg_print()

[alfredh]

Add usage of rtcp debug functions in testcode, to increase test coverage.

[alfredh]

Some jobs are stuck in the deadlock:

  test 98 -- test_rtmps_publish
  test 99 -- test_rtp
  test 100 -- test_rtpext
  test 101 -- test_rtcp_encode  <--- Stuck here

[alfredh]

it looks like the bitfields are promoted to int when printed:

	/** RTCP Header */
	struct rtcp_hdr {
		unsigned int version:2;  /**< Protocol version       */
		unsigned int p:1;        /**< Padding flag           */
		unsigned int count:5;    /**< Varies by packet type  */
		unsigned int pt:8;       /**< RTCP packet type       */
		uint16_t length;         /**< Packet length in words */
	} hdr;

[alfredh]

hi @sreimers

It looks like there is a problem with gcc and printing of bitfields.

In this code when printing bitfields, the _Generic hits the default case:

#define RE_ARG_SIZE(type)                                                     \
	_Generic((type),                                                      \
	bool:			sizeof(int),                                  \
	char:			sizeof(int),                                  \
	unsigned char:		sizeof(unsigned int),                         \
	short:			sizeof(int),                                  \
	unsigned short:		sizeof(unsigned int),	                      \
	int:			sizeof(int),                                  \
	unsigned int:		sizeof(unsigned int),                         \
	long:			sizeof(long),                                 \
	unsigned long:		sizeof(unsigned long),                        \
	long long:		sizeof(long long),                            \
	unsigned long long:	sizeof(unsigned long long),                   \
	float:			sizeof(double),                               \
	double:			sizeof(double),                               \
	char const*:		sizeof(char const *),                         \
	char*:			sizeof(char *),                               \
	void const*:		sizeof(void const *),                         \
	void*:			sizeof(void *),                               \
	struct pl:		sizeof(struct pl),                            \
	default: sizeof(void*)                                                \

Here is a simple test program to repro the case.
Please note than when using printf there are no compiler warnings.

#include <stdio.h>
#include <inttypes.h>
#include <re/re.h>


int main()
{
	struct rtcp_hdr hdr;

	hdr.version = 1;
	hdr.p = 1;
	hdr.count = 2;
	hdr.pt = 200;
	hdr.length = 3;

	re_printf("%8s pad=%d count=%-2d pt=%-3d len=%u \n",
	       rtcp_type_name((enum rtcp_type)hdr.pt),
	       hdr.p,
	       hdr.count,
	       hdr.pt,
	       hdr.length);
}

[sreimers]

The default promotion for variadic function args and small data types (bool, char, short) should be int or maybe higher, so yes this is wrong, unsure how to detect bit-fields nicely. I have to think about that.

[alfredh]

One option is to stop using bitfields, it seems to be compiler specific...

[sreimers]

I think I found a good workaround for bit fields: #1110

[sreimers]

Looks good, should we make a separat PR for this?

[alfredh]

This one is now ready for merge...