sip/transp: Allow ACK w/o Max-Forwards header #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredh
reviewed
May 19, 2024
src/sip/transp.c
Outdated
| @@ -334,7 +334,10 @@ static void sip_recv(struct sip *sip, const struct sip_msg *msg, | |||
|
|
|||
| if (msg->req) { | |||
| if (!have_essential_fields(msg)){ | |||
| (void)sip_reply(sip, msg, 400, "Bad Request"); | |||
| if (!pl_strcmp(&msg->met, "ACK")) | |||
| DEBUG_WARNING("Received bad ACK request\n"); | |||
There was a problem hiding this comment.
WARNING is perhaps a bit strict, perhaps INFO or DEBUG is better.
Remember what they said at IETF; Be conservative in what you send, be liberal in what you receive.
Perhaps also add some more info in the log message, for example
where is came from ?
There was a problem hiding this comment.
OK, I'll try to improve the message. About being liberal, pjsip does accept ACK w/o Max-Forwards. It really does not cause any harm in ACK.
|
Max-Forwards is decremented by one for each SIP proxy, and for the ACK request this header is not really so useful. It should be fine to accept incoming ACK w/o Max-Forwards header... |
juha-h
changed the title
|
Alfred E. Heggestad writes:
It should be fine to accept incoming ACK w/o Max-Forwards header...
Done.
|
sreimers
changed the title
sreimers
reviewed
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.