Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDP support for <proto> udp #538

Merged
merged 1 commit into from Oct 9, 2022
Merged

SDP support for <proto> udp #538

merged 1 commit into from Oct 9, 2022

Conversation

vanrein
Copy link
Contributor

@vanrein vanrein commented Sep 21, 2022

  • As per RFC 8866, without rtpmap and possibly with fmtp
  • This example shows [unregistered] media type application/vnd.wireguard
  • Wireshark does not like the fmtp: line -- that would be a bug there
v=0
o=- 3280287138 1947228850 IN IP6 2001:db8:12::34
s=-
c=IN IP6 2001:db8:12::34
t=0 0
m=application 9638 udp vnd.wireguard
a=fmtp:vnd.wireguard pubkey=z7otO6+NKCOM/I7gq6mvcVqYyX3u27Z0WVKMY/juel8=
a=sendrecv

include/re_fmt.h Outdated Show resolved Hide resolved
src/sdp/msg.c Outdated Show resolved Hide resolved
@vanrein
Copy link
Contributor Author

vanrein commented Sep 21, 2022

Style consistency makes sense, I agree. Very difficult to do when the fingers think they know what to type :)

src/sdp/str.c Outdated Show resolved Hide resolved
- As per RFC 8866, without rtpmap and possibly with fmtp
- This example shows [unregistered] media type application/vnd.wireguard
- Wireshark does not like the fmtp: line -- that would be a bug there

v=0
o=- 3280287138 1947228850 IN IP6 2001:db8:12::34
s=-
c=IN IP6 2001:db8:12::34
t=0 0
m=application 9638 udp vnd.wireguard
a=fmtp:vnd.wireguard pubkey=z7otO6+NKCOM/I7gq6mvcVqYyX3u27Z0WVKMY/juel8=
a=sendrecv
@vanrein
Copy link
Contributor Author

vanrein commented Oct 4, 2022

The re approach of standards compliance really pays off, I think. Thank you. I needed only this small change to do something that takes the standards to a rare corner, namely to negotatiate Wireguard tunnels. SDP support for UDP can exchange its endpoints, but also its keying material. Works like a charm. Not finished, but the code, config and man-page are already quite decent.

@sreimers sreimers merged commit 562528b into baresip:main Oct 9, 2022
@sreimers
Copy link
Member

sreimers commented Oct 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants