merge rem into re

[alfredh]

No description provided.

[robert-scheck]

May I kindly ask for some explanation? I'm not against this, I just would like to understand why rem will be merged into re.

[alfredh]

looks like the MinGW build is failing:

CMake Error: The source directory "/home/runner/work/re/re/baresip-win32/rem" does not exist.

I have also made a PR for baresip-win32 but I am not sure if it is picked up?

[sreimers]

I have also made a PR for baresip-win32 but I am not sure if it is picked up?

I think its not, can you try with dependency helper:

--- a/.github/workflows/mingw.yml
+++ b/.github/workflows/mingw.yml
@@ -34,9 +34,14 @@ jobs:
         repo: https://github.com/baresip/retest
         secret: ${{ secrets.GITHUB_TOKEN }}
 
-    - name: "clone baresip-win32 repo"
+    - uses: sreimers/pr-dependency-action@v0.5
+      with:
+        name: baresip-win32
+        repo: https://github.com/baresip/baresip-win32
+        secret: ${{ secrets.GITHUB_TOKEN }}
+
+    - name: "baresip-win32 repo"
       run: |
-        git clone https://github.com/baresip/baresip-win32.git
         mv rem baresip-win32/
         mv retest baresip-win32/

[sreimers]

May I kindly ask for some explanation? I'm not against this, I just would like to understand why rem will be merged into re.

from my perspective mainly to simplify maintenance and development, some benefits are:

• We can remove some PR dependency workarounds
• Improve CI Jobs (like coverage, remove redundant jobs)
• One Changelog/Release

[juha-h]

Tried on Debian. Worked OK, but debian/control needs librem dependency removed from line:

control:Depends: ${shlibs:Depends}, ${misc:Depends}, librem (>= 2.8.0), libre (>= 2.8.0)

Will try later on Android.

[alfredh]

related PRs:

#683

baresip/retest#184

baresip/baresip#2442

baresip/baresip-win32#10

[juha-h]

Now Debian libre build gave these warnings:

dpkg-shlibdeps: warning: symbol sqrt used by debian/libre/usr/lib/x86_64-linux-gnu/libre.so.14.12.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol sin used by debian/libre/usr/lib/x86_64-linux-gnu/libre.so.14.12.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol cos used by debian/libre/usr/lib/x86_64-linux-gnu/libre.so.14.12.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol lrint used by debian/libre/usr/lib/x86_64-linux-gnu/libre.so.14.12.0 found in none of the libraries
dpkg-shlibdeps: warning: symbol log10 used by debian/libre/usr/lib/x86_64-linux-gnu/libre.so.14.12.0 found in none of the libraries

[alfredh]

looks like linking to libm was missing...

@sreimers should we merge this to main now ?

[sreimers]

@sreimers should we merge this to main now ?

Yes, looks good to me. Thanks!