Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal topics API instead of calling topics lib directly, pass timestamp directly into method #63

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use internal topics API instead of calling topics lib directly, pass timestamp directly into method #63

wants to merge 5 commits into from

Conversation

julianlam
Copy link
Contributor

@julianlam julianlam commented Jun 16, 2024 •
edited
Loading

The PR contains two changes:

  1. Updates the topics.post call to call api.topics.create instead. This is to allow topics created via this plugin to be federated via activitypub
  2. Passes timestamp into the call instead of changing the sorted sets after the fact

@julianlam
Copy link
Contributor Author

julianlam commented Jun 16, 2024 •
edited
Loading

Don't merge yet; isEntryNew doesn't seem to work with this new logic.

@julianlam
Copy link
Contributor Author

Ah works fine if #64 is merged in as well.

@julianlam julianlam changed the title Use internal topics API instead of calling topics lib directly Use internal topics API instead of calling topics lib directly, pass timestamp directly into method Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julianlam