#63 fixed #67
Closed
#63 fixed #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
requested changes
Sep 9, 2020
proxy/proxy.go
Outdated
| rw := newResponseWriter(w) | ||
| rr := newResponseReader(resp) | ||
| err = p.proxyResponse(rw, rr, r.Header) | ||
| err = p.proxyResponse(rw, rr, r.Header, source_type) |
There was a problem hiding this comment.
proxyResponse takes four arguments and this fails in CI. Is this PR complete?
Also how does this work now that we have read resp.Body? Is it OK to read the stream again?
There was a problem hiding this comment.
I think it's OK to read resp.Body again, however it will be slower than read only once. Actually I'm not familiar with golang, is there a better option to complete it?
[fix] set the "content-type" response header instead of passing it to the proxyResponse function
|
@Web-Distortion is this PR still valid? Can you rebase it if so? |
|
This PR has been discarded and I will close it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.